[ovs-dev] [ovs-discuss] [PATCH] corekeeper: Always include PID in core dump names.
jpettit at nicira.com
Fri Aug 28 23:42:50 PDT 2009
Looks good to me.
On Aug 28, 2009, at 1:05 PM, Ben Pfaff wrote:
> Some distributions automatically set /proc/sys/kernel/core_uses_pid
> to 1
> and others leave it at its default setting of 0. That means that,
> with the
> core_pattern that corekeeper was setting, on the former
> distributions the
> PID would be included in core names and on the latter the PID would be
> omitted. For consistency, this commit forces the PID to be in the
> file name in either case (note that putting %p in core_pattern causes
> the core_uses_pid setting to be disregarded).
> CC: Martin Casado <casado at nicira.com>
> debian/corekeeper.init | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
> diff --git a/debian/corekeeper.init b/debian/corekeeper.init
> index 27d62a1..d820b02 100755
> --- a/debian/corekeeper.init
> +++ b/debian/corekeeper.init
> @@ -6,6 +6,7 @@
> # adjust it to the program you want to run.
> # Copyright (c) 2007 Javier Fernandez-Sanguino <jfs at debian.org>
> +# Copyright (c) 2009 Nicira Networks, Inc.
> # This is free software; you may redistribute it and/or modify
> # it under the terms of the GNU General Public License as
> @@ -42,7 +43,7 @@ set -e
> case "$1" in
> log_daemon_msg "Initializing core dump location..."
> - if echo "/var/log/core/core.%e.%t" > /proc/sys/kernel/
> + if echo "/var/log/core/core.%e.%t.%p" > /proc/sys/kernel/
> log_progress_msg "success"
> log_end_msg 0
> discuss mailing list
> discuss at openvswitch.org
More information about the dev