[ovs-dev] [PATCH] ofproto: Correctly credit stats for displaced rules.

Jesse Gross jesse at nicira.com
Thu Nov 12 15:22:25 PST 2009



Ben Pfaff wrote:
> Jesse Gross <jesse at nicira.com> writes:
>
>   
>> When a rule displaces another, we are supposed to credit the stats
>> for packets that have already been processed to the displaced rule
>> before we eject it from the datapath.  However, we were instead
>> crediting the new rule.
>>     
>
> Looks good.
>   

Thanks, I pushed it.

> Any chance you could look at the bug mentioned in the /* XXX */
> comment a few lines down in rule_update_actions()?  It would be
> nice to properly handle that situation too.
>   

I think I may have already fixed it in one of my other branches.  I'll 
see if I can dig that out.




More information about the dev mailing list