[ovs-dev] [PATCH 1/2] vswitchd: Add OVS version to database, give system info its own columns.
blp at nicira.com
Mon Dec 27 10:20:33 PST 2010
On Mon, Dec 27, 2010 at 10:14:57AM -0800, Justin Pettit wrote:
> On Dec 22, 2010, at 12:51 PM, Ben Pfaff wrote:
> > + <group title="Version Reporting">
> > + <p>
> > + These columns report the types and versions of the hardware and
> > + software running Open vSwitch. We recommend in general that software
> > + should test whether specific features are supported instead of relying
> > + on version number checks. These values are primarily intended for
> > + reporting to human administrators.
> > + </p>
> > +
> > + The Open vSwitch version number, e.g. <code>1.1.0pre2</code>. The Open
> > + vSwitch build number, if any, is not included.
> > + </column>
> I don't think there's an opening "column" tag for "ovs_version".
Yeah, I fixed this when I made the changes that Pete recommended.
> > + <column name="system_version">
> > + <p>
> > + The version of the system identified by <ref column="system_type"/>,
> > + e.g. <code>5.6.0</code> on XenServer 5.6.0.
> I know you just moved this from an existing description, but I think
> we may want to correct the example. For XenServer 5.6.0, I think it
> would be "5.6.0-31188", since we actually include the build number in
> our integration scripts.
OK, I checked it out on a real XenServer. It even includes the trailing
I changed the description to:
The version of the system identified by <ref column="system_type"/>,
e.g. <code>5.5.0-24648p</code> on XenServer 5.5.0 build 24648.
More information about the dev