[ovs-dev] [PATCH] datapath: Set datapath device MTU to minimum of MTU of ports.

Justin Pettit jpettit at nicira.com
Mon Feb 1 17:41:59 PST 2010


On Feb 1, 2010, at 2:04 PM, Jesse Gross wrote:

> +	case NETDEV_CHANGEMTU:
> +		if (p->port_no != ODPP_LOCAL) {

Would it make sense to check is_dp_dev() here instead?  The function set_dp_devs_mtu() just bails out if it's true anyways. It wouldn't be any more functionally correct, but I think it may be closer to the intention, plus avoids needlessly taking a mutex.

> +			mutex_lock(&dp->mutex);
> +			set_dp_devs_mtu(dp, dev);
> +			mutex_unlock(&dp->mutex);
> +		}
> +		break;
> 	}
> 	return NOTIFY_DONE;
> }

Otherwise, it looks good to me.

--Justin






More information about the dev mailing list