[ovs-dev] [PATCH] datapath: Set datapath device MTU to minimum of MTU of ports.

Jesse Gross jesse at nicira.com
Tue Feb 2 12:12:55 PST 2010


On Mon, Feb 1, 2010 at 8:41 PM, Justin Pettit <jpettit at nicira.com> wrote:

> On Feb 1, 2010, at 2:04 PM, Jesse Gross wrote:
>
> > +     case NETDEV_CHANGEMTU:
> > +             if (p->port_no != ODPP_LOCAL) {
>
> Would it make sense to check is_dp_dev() here instead?  The function
> set_dp_devs_mtu() just bails out if it's true anyways. It wouldn't be any
> more functionally correct, but I think it may be closer to the intention,
> plus avoids needlessly taking a mutex.
>

Yeah, you're right - this was supposed to be is_dp_dev().  The call in
dp_dp_devs_mtu() is there because there is another path into that function.
 Thanks, I updated and pushed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openvswitch.org/pipermail/dev/attachments/20100202/adf4f257/attachment.htm>


More information about the dev mailing list