[ovs-dev] [PATCH 09/15] vswitchd: Drop assignment whose value is never used in port_reconfigure().

Ben Pfaff blp at nicira.com
Wed Feb 10 11:30:32 PST 2010


Seems cleaner this way.

Found by Clang (http://clang-analyzer.llvm.org/).
---
 vswitchd/bridge.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 53b20e3..f097e18 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -3083,7 +3083,7 @@ port_reconfigure(struct port *port, const struct ovsrec_port *cfg)
 
         iface = shash_find_data(&old_ifaces, if_cfg->name);
         if (!iface) {
-            iface = iface_create(port, if_cfg);
+            iface_create(port, if_cfg);
         } else {
             iface->cfg = if_cfg;
         }
-- 
1.6.6.1





More information about the dev mailing list