[ovs-dev] [PATCH 15/15] ovs-ofctl: Drop assignment whose value is never used.

Ben Pfaff blp at nicira.com
Thu Feb 11 10:38:34 PST 2010


On Thu, Feb 11, 2010 at 11:43:50AM -0500, Jesse Gross wrote:
> On Wed, Feb 10, 2010 at 2:30 PM, Ben Pfaff <blp at nicira.com> wrote:
> >
> >  @@ -874,7 +874,7 @@ do_add_flows(int argc UNUSED, char *argv[])
> >         /* Parse and send.  str_to_flow() will expand and reallocate the
> > data
> >          * in 'buffer', so we can't keep pointers to across the
> > str_to_flow()
> >          * call. */
> > -        ofm = make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
> > +        make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
> >         str_to_flow(line, &match, buffer,
> >                     NULL, NULL, &priority, &idle_timeout, &hard_timeout);
> >         ofm = buffer->data;
> 
> I think maybe it would be cleaner to just drop the second assignment
> instead.  It's the same thing but seems simpler and more consistent with
> what we do in other places.

We can't drop the second assignment (see the comment).




More information about the dev mailing list