[ovs-dev] [PATCH 15/15] ovs-ofctl: Drop assignment whose value is never used.

Ben Pfaff blp at nicira.com
Thu Feb 11 10:40:08 PST 2010


Thanks.  I pushed this out.

On Thu, Feb 11, 2010 at 11:45:25AM -0500, Jesse Gross wrote:
> All the patches in the set look good with the exception of the two that I
> commented on.  A couple of nasty bugs in there...
> 
> On Wed, Feb 10, 2010 at 2:43 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Found by Clang (http://clang-analyzer.llvm.org).
> > ---
> >  utilities/ovs-ofctl.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> > index 2447ba2..7f24309 100644
> > --- a/utilities/ovs-ofctl.c
> > +++ b/utilities/ovs-ofctl.c
> > @@ -874,7 +874,7 @@ do_add_flows(int argc UNUSED, char *argv[])
> >         /* Parse and send.  str_to_flow() will expand and reallocate the
> > data
> >          * in 'buffer', so we can't keep pointers to across the
> > str_to_flow()
> >          * call. */
> > -        ofm = make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
> > +        make_openflow(sizeof *ofm, OFPT_FLOW_MOD, &buffer);
> >         str_to_flow(line, &match, buffer,
> >                     NULL, NULL, &priority, &idle_timeout, &hard_timeout);
> >         ofm = buffer->data;




More information about the dev mailing list