[ovs-dev] [PATCH 01/16] dpif-netdev: Fix validation of VLAN PCP value in userspace datapath.

Ben Pfaff blp at nicira.com
Fri Feb 12 13:56:10 PST 2010


On Fri, Feb 12, 2010 at 04:39:38PM -0500, Jesse Gross wrote:
> On Thu, Feb 11, 2010 at 6:18 PM, Ben Pfaff <blp at nicira.com> wrote:
> >
> >
> >  #define VLAN_VID_MASK 0x0fff
> > +#define VLAN_VID_SHIFT 0
> > +
> >  #define VLAN_PCP_MASK 0xe000
> > +#define VLAN_PCP_SHIFT 13
> 
> 
> We should use these shift values everywhere - there is another place in the
> code that still uses 13 instead of VLAN_PCP_SHIFT.  Also, for consistency it
> would be nice to use VLAN_VID_SHIFT, even if it is 0.

Thanks.

I'll send out separate patches.




More information about the dev mailing list