[ovs-dev] [PATCH 5/5] Use VLAN_VID_SHIFT, even though it is 0, for consistency.

Ben Pfaff blp at nicira.com
Sat Feb 13 10:12:58 PST 2010


On Fri, Feb 12, 2010 at 10:03:57PM -0800, Justin Pettit wrote:
> On Feb 12, 2010, at 9:15 PM, Jesse Gross wrote:
> 
> > On Fri, Feb 12, 2010 at 9:36 PM, Justin Pettit <jpettit at nicira.com> wrote:
> > I was looking at the function dp_netdev_modify_vlan_tci() in
> > dpif-netdev.c.  Doesn't it seem like we should be applying the mask
> > to the passed in value, too?  So, this:
> > 
> > We could do that but we validate the actions when the flows are added so they should already be in the correct range.
> 
> Yeah.  I still think it would be good to make the function actually
> correct in case it ever gets used elsewhere.  I'll send it out later,
> but I realize it's super low priority.

I'd rather add a comment explaining that the caller is responsible for
doing validation.




More information about the dev mailing list