[ovs-dev] [PATCH 10/14] ovsdb: Allow ovsdb_log_open()'s caller to choose whether to lock.

Ben Pfaff blp at nicira.com
Mon Feb 15 11:34:45 PST 2010


On Fri, Feb 12, 2010 at 06:47:18PM -0500, Jesse Gross wrote:
> On Fri, Feb 12, 2010 at 2:37 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > The current callers of ovsdb_log_open() always want to log the file if
> 
> Should that be "lock the file"?

Yes, thanks, I fixed it up.

> 
> > +    assert(locking == -1 || locking == false || locking == true);
> 
>  Would it be nicer to create an enum?

I did think so at first, so I created one and sprinkled it throughout
the code.  But the more I looked at it the less I liked it; it made lots
of lines longer and wrap around, but didn't really clarify much.  So I
ended up with this.




More information about the dev mailing list