[ovs-dev] [PATCH 5/5] Use VLAN_VID_SHIFT, even though it is 0, for consistency.

Ben Pfaff blp at nicira.com
Mon Feb 15 13:19:30 PST 2010


On Mon, Feb 15, 2010 at 04:17:13PM -0500, Jesse Gross wrote:
> On Mon, Feb 15, 2010 at 4:15 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > I pushed out the first four out of the five patches.  I'm still sitting
> > on 5/5 here trying to decide whether it's worth it.  I don't like it
> > much myself, and Justin sounded negative about it too (although part of
> > that was just confusion I guess).
> >
> > Do you have strong feelings about it, Jesse (or anyone else)?
> 
>  No, not really.  It seemed nice in theory but it is pretty ugly and
> pointless in practice.

Thanks, I'll drop it then.




More information about the dev mailing list