[ovs-dev] [PATCH 2/2] xenserver: Various cleanups to get OVS to work with XenServer 5.5
jpettit at nicira.com
Thu Feb 18 16:34:54 PST 2010
On Feb 18, 2010, at 1:13 PM, Ben Pfaff wrote:
>> diff --git a/xenserver/opt_xensource_libexec_InterfaceReconfigureVswitch.py b/xenserver/opt_xensource_libexec_InterfaceReconfigureVswitch.py
>> index 7ba0d24..a9020c4 100644
> But I don't understand this. configure_datapath() doesn't do anything
> with its new 'parent' or 'vlan' arguments (you didn't add any code to do
> anything with them), so I don't understand what this actually changes.
As we discussed offline, interface-reconfigure is a mess everywhere but the "citrix" branch. I killed my changes to InterfaceReconfigureVswitch.py, since the problems are more serious than my addition of this essentially no-op.
For everyone else, Ben's been kind enough to devote tomorrow to fixing interface-reconfigure in the "next" branch. Since "next" and "master" have fundamentally different ways of handling configuration, the effort to get "master" straightened out is nontrivial. The "next" branch should be merged into "master" before too long.
I went ahead and pushed the changes to the "vif" script, since that was causing the most problems for external people. I'll a spin a new unstable release with this change soon.
More information about the dev