[ovs-dev] [PATCH 09/12] xenserver: Add assertion and additional comments to ovs-vsctl commands.

Ben Pfaff blp at nicira.com
Mon Feb 22 16:42:45 PST 2010


I found these useful while debugging.
---
 ...ensource_libexec_InterfaceReconfigureVswitch.py |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/xenserver/opt_xensource_libexec_InterfaceReconfigureVswitch.py b/xenserver/opt_xensource_libexec_InterfaceReconfigureVswitch.py
index 99eca11..948e17d 100644
--- a/xenserver/opt_xensource_libexec_InterfaceReconfigureVswitch.py
+++ b/xenserver/opt_xensource_libexec_InterfaceReconfigureVswitch.py
@@ -187,10 +187,13 @@ def configure_datapath(pif):
     vsctl_argv = []
     extra_up_ports = []
 
+    assert not pif_is_vlan(pif)
     bridge = pif_bridge_name(pif)
 
     physical_devices = datapath_get_physical_pifs(pif)
 
+    vsctl_argv += ['## configuring datapath %s' % bridge]
+
     # Determine additional devices to deconfigure.
     #
     # Given all physical devices which are part of this PIF we need to
@@ -274,6 +277,8 @@ def configure_datapath(pif):
         vsctl_argv += ['--', '--may-exist', 'add-port', bridge, iface]
 
     vsctl_argv += set_br_external_ids(pif)
+    vsctl_argv += ['## done configuring datapath %s' % bridge]
+
     return vsctl_argv,extra_up_ports
 
 def deconfigure_bridge(pif):
-- 
1.6.6.1





More information about the dev mailing list