[ovs-dev] openflow-1.0 : enum ofp_config_flags isn't based upon OpenFlow 1.0

Justin Pettit jpettit at nicira.com
Tue Feb 23 00:14:06 PST 2010


Thank you for pointing that out.  I'll make sure a fix for that goes out tomorrow.

--Justin


On Feb 22, 2010, at 10:23 PM, Tetsuo NAKAGAWA wrote:

> Hi.
> 
> I'm using Open vSwitch with openflow-1.0 branch.
> 
> enum ofp_config_flags is defined as follows in
> include/openflow/openflow.h.
> 
>  enum ofp_config_flags {
>      /* Handling of IP fragments. */
>      OFPC_FRAG_NORMAL   = 0 << 1,  /* No special handling for fragments. */
>      OFPC_FRAG_DROP     = 1 << 1,  /* Drop fragments. */
>      OFPC_FRAG_REASM    = 2 << 1,  /* Reassemble (only if OFPC_IP_REASM set). */
>      OFPC_FRAG_MASK     = 3 << 1
>  };  
> 
> But, it's described as follows in "OpenFlow Switch
> Specification Version 1.0.0".
> 
>  5.3.2 Switch Configuration
> 
>    (snip)
> 
>  The configuration flags include the following:
> 
>  enum ofp_config_flags {
>      /* Handling of IP fragments. */
>      OFPC_FRAG_NORMAL = 0,  /* No special handling for fragments. */
>      OFPC_FRAG_DROP   = 1,  /* Drop fragments. */
>      OFPC_FRAG_REASM  = 2,  /* Reassemble (only if OFPC_IP_REASM set). */
>      OFPC_FRAG_MASK   = 3
>  };
> 
> Please fix a definition of enum ofp_config_flags to based
> upon OpenFlow 1.0.
> 
> best regards,
> 
> --- Tetsuo NAKAGAWA
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list