[ovs-dev] [PATCH 01/12] xenserver: Fix comment in interface-reconfigure.

Ian Campbell Ian.Campbell at citrix.com
Tue Feb 23 02:20:10 PST 2010


I made some minor comments on individual patches but generally all looks
fine to me (take with a pinch of salt given my lack of knowledge of the
next branch).

The unit test stuff looks nice, if only I could steal it without
learning m4 ;-) I've attached the unit test I use plus a script which
will setup a XenServer host appropriately. They might be a little
Ian-specific and are completely devoid of comments but feel free to ask
if you are interested in using or cribbing from them and something isn't
clear.

I assume these will these end up with a Signed-off-by etc when they
committed? At some point in the future, as part of moving XCP and
XenServer over to the next branch, I'll want to cherry-pick these
changes and upstream them to the XCP project which will require a
signed-off-by.

Thanks,
Ian.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: interface-reconfigure-test
Type: text/x-python
Size: 27991 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/dev/attachments/20100223/6c5df0ca/attachment.py>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: interface-reconfigure-test-setup
Type: application/x-shellscript
Size: 895 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/dev/attachments/20100223/6c5df0ca/attachment.bin>


More information about the dev mailing list