[ovs-dev] [PATCH 4/9] vconn: Convert vconn code to modern OVS structure.

Justin Pettit jpettit at nicira.com
Wed Jan 6 13:15:03 PST 2010


On Dec 21, 2009, at 1:15 PM, Ben Pfaff wrote:

> diff --git a/lib/vconn.c b/lib/vconn.c
> index 1c440fb..f11d7a5 100644
> --- a/lib/vconn.c
> +++ b/lib/vconn.c
> @@ -90,10 +90,13 @@ check_vconn_classes(void)
>         struct vconn_class *class = vconn_classes[i];
>         assert(class->name != NULL);
>         assert(class->open != NULL);
> -        if (class->close || class->recv || class->send || class->wait) {
> +        if (class->close || class->recv || class->send
> +            || class->run || class->run_wait || class->wait) {
>             assert(class->close != NULL);
>             assert(class->recv != NULL);
>             assert(class->send != NULL);
> +            assert(class->run != NULL);
> +            assert(class->run_wait != NULL);

This is the same question as I raised previously: is it guaranteed that "run" and "run_wait" are defined if any of them are?  The comments above their description sounds as if they may be null.

Otherwise, it seems reasonable from my quick read-through.

--Justin






More information about the dev mailing list