[ovs-dev] [PATCH 4/7] stream-ssl: Try to shut SSL connections down gracefully.

[Justin Pettit]

Looks good.

--Justin


On Jan 7, 2010, at 3:01 PM, Ben Pfaff wrote:

> It's nice to shut down SSL connections gracefully when we can.
> ---
> lib/stream-ssl.c |    8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/stream-ssl.c b/lib/stream-ssl.c
> index 11bbf4a..436dc7b 100644
> --- a/lib/stream-ssl.c
> +++ b/lib/stream-ssl.c
> @@ -437,6 +437,14 @@ ssl_close(struct stream *stream)
> {
>     struct ssl_stream *sslv = ssl_stream_cast(stream);
>     ssl_clear_txbuf(sslv);
> +
> +    /* Attempt clean shutdown of the SSL connection.  This will work most of
> +     * the time, as long as the kernel send buffer has some free space and the
> +     * SSL connection isn't renegotiating, etc.  That has to be good enough,
> +     * since we don't have any way to continue the close operation in the
> +     * background. */
> +    SSL_shutdown(sslv->ssl);
> +
>     SSL_free(sslv->ssl);
>     close(sslv->fd);
>     free(sslv);
> -- 
> 1.6.3.3
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org