[ovs-dev] [PATCH 08/13] json: Export function to parse an individual JSON string.

Ben Pfaff blp at nicira.com
Tue Jan 26 09:49:14 PST 2010


On Mon, Jan 25, 2010 at 05:04:53PM -0500, Jesse Gross wrote:
>  Looks good, one comment:
> 
> -static void
> > -json_lex_string(struct json_parser *p)
> > +bool
> > +json_string_unescape(const char *in, size_t in_len, char **outp)
> >  {

[...]

> > +    ds_init(&out);
> > +    ds_reserve(&out, strlen(in));
> >
> 
> Shouldn't strlen(in) be in_len?

Ouch!  Thank you very much, I updated the commit.




More information about the dev mailing list