[ovs-dev] [PATCH] datapath: Don't update flow key when applying actions.
blp at nicira.com
Thu Jul 15 13:22:06 PDT 2010
On Thu, Jul 15, 2010 at 01:14:28PM -0700, Jesse Gross wrote:
> On Thu, Jul 15, 2010 at 1:09 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Jul 15, 2010 at 01:03:58PM -0700, Jesse Gross wrote:
> > > Currently the flow key is updated to match an action that is applied
> > > to a packet but these field are never looked at again. Not only is
> > > this a waste of time it also makes optimizations involving caching
> > > the flow key more difficult.
> > We deliberately un-optimized this back in March, on the basis that "we
> > sometimes use the key for checks later on":
> I know I did this before. Really, I'm just trying to boost my commit
You only have 345 to go before you pass Justin, assuming he doesn't
commit anything else in the meantime. Might take another late night or
> We do look at the key at certain points but not for fields that change (the
> fields we look at are dl_type and nw_proto). Before I really just wanted to
> be consistent about and thought that it was best to always keep it up to
> date. However, this causes problems with some of the optimizations I'm
> planning, so now I think we should be consistent in the opposite direction.
Fair enough. I'll go back and look at the actual code changes then.
More information about the dev