[ovs-dev] [QoS fixes 08/10] dpif-linux: Translate queues to priorities correctly.

Justin Pettit jpettit at nicira.com
Mon Jul 19 18:58:05 PDT 2010


Looks good.

--Justin


On Jul 16, 2010, at 3:52 PM, Ben Pfaff wrote:

> The TC_H_MAKE macro does not shift the major number into position.
> ---
> lib/dpif-linux.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
> index 87f29f8..a28355d 100644
> --- a/lib/dpif-linux.c
> +++ b/lib/dpif-linux.c
> @@ -463,7 +463,7 @@ dpif_linux_queue_to_priority(const struct dpif *dpif OVS_UNUSED,
>                              uint32_t queue_id, uint32_t *priority)
> {
>     if (queue_id < 0xf000) {
> -        *priority = TC_H_MAKE(1, queue_id);
> +        *priority = TC_H_MAKE(1 << 16, queue_id);
>         return 0;
>     } else {
>         return EINVAL;
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list