[ovs-dev] [QoS fixes 10/10] netdev-linux: Avoid minor number 0 in traffic control.

Ben Pfaff blp at nicira.com
Tue Jul 20 11:24:50 PDT 2010


On Mon, Jul 19, 2010 at 10:27:45PM -0700, Justin Pettit wrote:
> On Jul 16, 2010, at 3:52 PM, Ben Pfaff wrote:
> 
> >     if (queue_id < 0xf000) {
> > -        *priority = TC_H_MAKE(1 << 16, queue_id);
> > +        *priority = TC_H_MAKE(1 << 16, queue_id + 1);
> 
> The number of HTB queues is hardcoded to 0xf000 in netdev-linux.c, so
> will increasing the minor handle by one cause any issues here?  I'm
> guessing you considered this, but I'm fairly ignorant on the kernel TC
> stuff and just want to double check.

I only hardcoded it to 0xf000 to give some extra minor numbers for
internal use in case we ever need any.  The whole range from 1 up to
0xfffe is available as far as I know.  So adding 1 should be OK.

Thanks for all the reviews.




More information about the dev mailing list