[ovs-dev] [PATCH] vlog: Fix logic error in update_min_level().

Ben Pfaff blp at nicira.com
Fri Jul 23 15:27:51 PDT 2010


Commit 480ce8ab "vlog: Make the vlog module catalog program-specific."
accidentally inverted the logic in this function, which broke the "-v"
to various OVS programs as well as other mechanisms to set logging to
non-default levels.
---
 lib/vlog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/vlog.c b/lib/vlog.c
index 1c6d25b..ddda266 100644
--- a/lib/vlog.c
+++ b/lib/vlog.c
@@ -189,7 +189,7 @@ update_min_level(struct vlog_module *module)
     for (facility = 0; facility < VLF_N_FACILITIES; facility++) {
         if (log_file || facility != VLF_FILE) {
             enum vlog_level level = module->levels[facility];
-            if (level < module->min_level) {
+            if (level > module->min_level) {
                 module->min_level = level;
             }
         }
-- 
1.7.1





More information about the dev mailing list