[ovs-dev] [loops 3/6] datapath: Change vport_send() to return negative error values.
jesse at nicira.com
Tue Jul 27 12:28:13 PDT 2010
On Tue, Jul 27, 2010 at 10:07 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Jul 26, 2010 at 04:37:19PM -0700, Jesse Gross wrote:
> > On Fri, Jul 23, 2010 at 4:44 PM, Ben Pfaff <blp at nicira.com> wrote:
> > >
> > > @@ -1262,19 +1264,20 @@ int vport_send(struct vport *vport, struct
> > > *skb)
> > > if (net_ratelimit())
> > > printk(KERN_WARNING "%s: dropped over-mtu
> packet: %d
> > > > %d\n",
> > > dp_name(vport_get_dp_port(vport)->dp),
> > > packet_length(skb), mtu);
> > > + retval = 0;
> > Is it worth returning an actual error code here? We don't really need it
> > for anything but if we are reporting status we might as well make it as
> > useful as possible. Maybe -E2BIG?
> Is that an error that should cause all of the actions for the current
> flow to be aborted? It's possible that some devices on the datapath
> have MTUs big enough for the packet and others don't. If we return 0,
> then those devices can get a chance at it too.
Probably not, we might as well try all the ports (though strictly speaking
according to 802.1d we should probably abort since they consider having
ports with different MTUs in a single bridge to be a fundamental problem).
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the dev