[ovs-dev] [PATCH] vswitchd: Add entity-relationship diagram to ovs-vswitchd.conf.db.5.
jesse at nicira.com
Tue Jun 22 18:45:06 PDT 2010
On Tue, Jun 22, 2010 at 11:47 AM, Ben Pfaff <blp at nicira.com> wrote:
> +dnl Checks for dot.
> + [AC_CACHE_CHECK(
> + [for dot],
> + [ovs_cv_dot],
> + [dnl "dot" writes -V output to stderr:
> + if (dot -V) 2>&1 | grep Graphviz >/dev/null 2>&1; then
> + ovs_cv_dot=yes
> + else
> + ovs_cv_dot=no
> + fi])])
If we're going to make our behavior conditional based on whether Graphviz is
installed should we document that somewhere?
Also, on Ubuntu "dot -V" when it isn't installed results in:
The program 'dot' is currently not installed. You can install it by typing:
sudo apt-get install graphviz
So this test works but only due to the difference in capitalization.
> diff --git a/vswitchd/vswitch.pic b/vswitchd/vswitch.pic
> new file mode 100644
> index 0000000..67c3338
> --- /dev/null
> +++ b/vswitchd/vswitch.pic
Are we trying to autogenerate this file?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the dev