[ovs-dev] [PATCH] netflow: Back-out optimization that could lead to infinite loop
blp at nicira.com
Tue Oct 12 11:41:14 PDT 2010
On Tue, Oct 12, 2010 at 11:33:51AM -0700, Justin Pettit wrote:
> Commit 924282 (netflow: Do 64-bit division less often.) attempted to
> remove the 64-bit division used to break flow records with large byte
> counts into multiple NetFlow records. The calculation to determine the
> number of records was incorrect and should have shifted "byte_delta" by
> 31 instead of 32. This commit reverts the change (while keeping commit
> f22a24 (netflow: Avoid (theoretically) looping 2**32 times.) ), since
> the logic is more straight-forward than the optimized version.
Looks good to me.
More information about the dev