[ovs-dev] [PATCH] lib: Fix warnings

Ben Pfaff blp at nicira.com
Thu Oct 14 15:48:41 PDT 2010


A build failure is much more important than just a warning.  Mention
that problem in the change log and push it.

On Thu, Oct 14, 2010 at 03:45:27PM -0700, Ethan Jackson wrote:
> Oh sorry,  I get an undefined symbol for fstat and stat.
> 
> Ethan Jackson
> 
> On Thu, Oct 14, 2010 at 3:44 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Oct 14, 2010 at 03:39:34PM -0700, Ethan Jackson wrote:
> >> Works for me.  Do you want to include the other part of my patch as well?
> >>
> >> diff --git a/lib/daemon.c b/lib/daemon.c
> >> index bbcfe6a..bc28973 100644
> >> --- a/lib/daemon.c
> >> +++ b/lib/daemon.c
> >> @@ -23,6 +23,7 @@
> >>  #include <string.h>
> >>  #include <sys/resource.h>
> >>  #include <sys/wait.h>
> >> +#include <sys/stat.h>
> >>  #include <unistd.h>
> >>  #include "command-line.h"
> >>  #include "fatal-signal.h"
> >>
> >> Or I can submit that with the original patch after you submit this one.
> >
> > Thank.  I pushed my patch.  Why don't you add the daemon.c one
> > separately?  (I don't think I ever heard back on what warning it fixes,
> > but it looks harmless at least.)
> >




More information about the dev mailing list