[ovs-dev] [PATCH] datapath: Simplify ODPAT_SET_DL_TCI action.

Ben Pfaff blp at nicira.com
Mon Oct 18 11:19:16 PDT 2010


On Fri, Oct 15, 2010 at 04:00:05PM -0700, Jesse Gross wrote:
> On Tue, Oct 12, 2010 at 11:40 AM, Ben Pfaff <blp at nicira.com> wrote:
> > There's no need to have a mask in this action, because both parts of the
> > TCI are part of the flow structure.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > So far, this is oompile-tested only, so there could be some really
> > stupid things in it.
> 
> The only problem that I see is the above sentence.  You don't seem to
> have run it through your oompiler.
> 
> Otherwise I like the simplification.
> Acked-by: Jesse Gross <jesse at nicira.com>

Thanks.

The oompa loompas also acked it, so I pushed this along.




More information about the dev mailing list