[ovs-dev] [PATCH 1/2] debian: Init script should put core dumps in an appropriate place

Ethan Jackson ethan at nicira.com
Thu Sep 16 11:13:10 PDT 2010


Yah I was intending to use my @nicira address,  I'm not quite sure why git
decided to use my personal address, I will have to investigate.

Ethan

On Thu, Sep 16, 2010 at 9:22 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Sep 14, 2010 at 08:15:28PM -0700, Ethan Jackson wrote:
> > From: Ethan Jackson <ejj at ej2.org>
>
> You should probably use your @nicira.com address for commits.
>
> You should add yourself to AUTHORS as part of your first commit.
>
> Looks good, one other comment:
>
> > @@ -245,6 +249,7 @@ case "$1" in
> >          echo -n "Starting ovsdb-server: "
> >          start-stop-daemon --start --quiet \
> >              --pidfile /var/run/openvswitch/ovsdb-server.pid \
> > +            -d /var/log/openvswitch/cores                   \
> >              --exec $ovsdb_server -- "$@"
> >          if running ovsdb-server; then
> >              echo "ovsdb-server."
> > @@ -258,12 +263,13 @@ case "$1" in
>
> The rest of the options to start-stop-daemon use the long form, so let's
> use --chdir instead of -d for consistency.  Ditto in the other three
> places in the script.
>
> Thanks Ethan, welcome to the repository.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openvswitch.org/pipermail/dev/attachments/20100916/a1601709/attachment.htm>


More information about the dev mailing list