[ovs-dev] [PATCH 4/7] datapath: Move is_frag out of struct ovs_skb_cb.
jesse at nicira.com
Tue Sep 21 17:14:14 PDT 2010
On Mon, Sep 20, 2010 at 1:23 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Sep 20, 2010 at 11:13:42AM -0700, Jesse Gross wrote:
>> is_frag is only used for communication between two functions, which
>> means that it doesn't really need to be in the SKB CB. This wouldn't
>> necessarily be a problem except that there are also a number of other
>> paths that lead to this being uninitialized. This isn't a problem
>> now but uninitialized memory seems dangerous and there isn't much
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
> Seems OK.
> I'd be half-inclined to embed odp_flow_key in a larger structure that
> has an odp_flow_key and a bool is_frag, and then pass that to
> flow_extract(), but I imagine that it is not worth it.x
That seems reasonable but the benefit also seems pretty low, so I left it as is.
More information about the dev