[ovs-dev] [vlog-levels v2 1/2] vlog: Add a new log level "off".
jpettit at nicira.com
Mon Aug 1 13:30:21 PDT 2011
On Jul 30, 2011, at 1:44 PM, Justin Pettit wrote:
> On Jul 28, 2011, at 10:19 AM, Ben Pfaff wrote:
>> /* More convenience macros, for testing whether a given level is enabled in
>> * THIS_MODULE. When constructing a log message is expensive, this enables it
>> * to be skipped. */
>> -#define VLOG_IS_EMER_ENABLED() true
>> #define VLOG_IS_ERR_ENABLED() vlog_is_enabled(THIS_MODULE, VLL_ERR)
> Do you think not having a VLOG_IS_EMER_ENABLED is useful? I guess those shouldn't be printed in much volume.
> Otherwise, looks good to me.
You had mentioned you'd like to get this series into the 1.2.0 release. I've gone ahead and pushed this patch as is, since I want to get the changes frozen today. If you think adding VLOG_IS_EMER_ENABLED is useful, we can do it as a separate patch later.
More information about the dev