[ovs-dev] [PATCH] netdev: Disallow creation of netdevs with unsupported options.
jesse at nicira.com
Tue Aug 2 20:54:02 PDT 2011
On Wed, Aug 3, 2011 at 5:35 AM, Ethan Jackson <ethan at nicira.com> wrote:
> Before this patch, if an interface was created with an unsupported
> key in its options column, ovs-vswitchd would ignore the offending
> key and create the interface. Later on, if ovs-vswitchd was
> restarted, it would recreate netdevs for the interfaces in the
> datapath. Then it would attempt to create netdevs for interfaces
> in the database, ignoring any that had equivalent configuration to
> a device already in the datapath. Ovs-vswitchd would fail to
> recognize the datapath device as equivalent to the database device
> because the database device would have the unsupported key in its
> configuration which the datapath device did not. This would render
> the switch in an inconsistent state.
> This patch fixes the issue by disallowing the creation of netdevs
> with unsupported configuration options.
Currently in netdev-vport.c:parse_tunnel_config() we just warn if
there is an unknown option. I think if we simply returned an error at
that point it would have the same effect and we wouldn't need to
duplicate the logic for valid options.
More information about the dev