[ovs-dev] [rspan 2/2] Document and warn that mirroring to a VLAN is incompatible with SLB bonding.

Ethan Jackson ethan at nicira.com
Fri Aug 5 18:22:07 PDT 2011


This seems fine, I would go slightly further though.


> +    if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
> +        VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "
> +                  "please use another bond type or disable flood_vlans",
> +                  port->name);
> +    }

I would change this warning to an error, and actually fail to create
the port in this case.  I'm afraid people are going to ignore the
warning in the log.  If you disagree, go ahead and merge.

Ethan



More information about the dev mailing list