[ovs-dev] [PATCH 3/6] flow: New FLOW_WC_SEQ build assertion.
blp at nicira.com
Thu Aug 11 10:53:54 PDT 2011
Looks good, thank you.
On Thu, Aug 11, 2011 at 10:48:40AM -0700, Ethan Jackson wrote:
> Thanks for the review, I added the following comment.
> /* This sequence number should be incremented whenever anything involving flows
> * or the wildcarding of flows changes. This will cause build assertion
> * failures in places which likely need to be updated. */
> #define FLOW_WC_SEQ 1
> On Wed, Aug 10, 2011 at 22:16, Ben Pfaff <blp at nicira.com> wrote:
> > On Wed, Aug 10, 2011 at 05:21:40PM -0700, Ethan Jackson wrote:
> >> Changing "struct flow" or its wildcards requires minor adjustments
> >> in many places in the code. ?This patch adds a new FLOW_WC_SEQ
> >> sequence number which when incremented will cause build assertion
> >> failures aiding the developer in finding code which needs to
> >> change.
> > I think that FLOW_WC_SEQ itself deserves a comment.
> > Otherwise this looks good, thank you.
More information about the dev