[ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

[Jesse Gross]

On Aug 18, 2011 4:30 AM, "Philippe Jung" <phil.jung at free.fr> wrote:
>
> Le 17/08/2011 03:37, Jesse Gross a écrit :
>
> >
> > This is the same as native vlan, right?  If so, I think that is a
> > better name as it is more common and PVID sounds like it should refer
> > to private vlans.
>
> Yes, also called default VLAN. Do I make the change just in comments or
> also in the new column called vlan_mode? Currently, allowed values are:
> - empty
> - access
> - trunk
> - pvid
> - untagged-pvid.
>
> I could change the values for
> - empty
> - access
> - trunk
> - tagged-native
> - untagged-native

I would make the change everywhere. The above list looks good, although I
think it might be better to reverse the native names (i.e. "native-tagged"
instead of "tagged-native") as it groups things together a little better.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openvswitch.org/pipermail/dev/attachments/20110818/9b21cc94/attachment.htm>