[ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature
blp at nicira.com
Mon Aug 22 13:27:05 PDT 2011
On Mon, Aug 22, 2011 at 10:17:03PM +0200, Philippe Jung wrote:
> In original ofproto-dpif.c, line 1058, I read
> 1058 /* Get trunked VLANs. */
> 1059 trunks = s->vlan == -1 ? NULL : s->trunks;
> Is there a reason to explain that when the port is trunk (vlan=-1),
> trunks is set to nul and when port is access (vlan<>-1) trunks is set to
> s->trunk ? I would have inverted the test case.
I think you're right. I guess nobody (except you) tests trunking a
limited set of VLANs. We should fix this, thanks for the bug report.
More information about the dev