[ovs-dev] [gc 04/13] ovsdb: Improve error reporting for some internal errors.

Ethan Jackson ethan at nicira.com
Fri Mar 4 13:36:29 PST 2011


> +#define OVSDB_BUG(MSG)                                      \
> +    ovsdb_internal_error(NULL, __FILE__, __LINE__, "%s", MSG)
> +#define OVSDB_WRAP_BUG(MSG, ERROR)                          \
> +    ovsdb_internal_error(ERROR, __FILE__, __LINE__, "%s", MSG)

I think a comment to the effect that OVSDB_WRAP_BUG takes ownership of
'ERROR' might be useful.   I was surprised at that when reading the
code.  Your call though, it's fine either way.


Looks Good.
Ethan




More information about the dev mailing list