[ovs-dev] [PATCH] netdev-vport: Warn on IPsec tunnels when ovs-monitor-ipsec not running.

Andrew Evans aevans at nicira.com
Sat Mar 12 10:55:55 PST 2011


On 03/12/11 08:49, Andrew Evans wrote:
> On 03/11/11 22:13, Justin Pettit wrote:
>> doesn't actually know whether IPsec will actually work. With this
>
> I think this reads better with the first 'actually' omitted.
>
>> Bug #4854
>
> I think there should be a period at the end of the line.
>
>> + if (pid<0 || kill(pid, 0)) {

I think we can do away with this and simply use the return value of 
read_pidfile() to decide whether the daemon is running or not.

-Andrew



More information about the dev mailing list