[ovs-dev] [PATCH 1/2] debian: Run tests in parallel too.

[Ethan Jackson]

yay!  Looks good to me assuming make distcheck passes.

I wonder if there would be a reason to optionally disable it with
configure somehow.  That way we could avoid running the tests in
parallel in the builds in case they trample on each other.  That may
be overly cautious though.  At any rate I don't think something like
that needs to go into this patch.

Ethan

On Mon, Mar 14, 2011 at 3:16 PM, Ben Pfaff <blp at nicira.com> wrote:
> Passing e.g. -j4 in TESTSUITEFLAGS runs 4 tests in parallel, which speeds
> up the testsuite.
> ---
> &nbsp;debian/rules | &nbsp; &nbsp;9 ++++++---
> &nbsp;1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/debian/rules b/debian/rules
> index bbc7357..de79800 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -14,9 +14,11 @@
> &nbsp;BUILD_NUMBER = 0
>
> &nbsp;ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
> -NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
> -MAKEFLAGS += -j$(NUMJOBS)
> +PARALLEL = -j$(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
> +else
> +PARALLEL =
> &nbsp;endif
> +MAKEFLAGS += $(PARALLEL)
>
> &nbsp;ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
> &nbsp;CFLAGS += -O0
> @@ -45,7 +47,8 @@ build-arch: build-arch-stamp
> &nbsp;build-arch-stamp: configure-stamp
> &nbsp; &nbsp; &nbsp; &nbsp;$(MAKE) -C _debian
> &nbsp;ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
> - &nbsp; &nbsp; &nbsp; if $(MAKE) -C _debian check; then :; else \
> + &nbsp; &nbsp; &nbsp; if $(MAKE) -C _debian check TESTSUITEFLAGS='$(PARALLEL)'; then :; \
> + &nbsp; &nbsp; &nbsp; else \
> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;cat _debian/tests/testsuite.log; \
> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;exit 1; \
> &nbsp; &nbsp; &nbsp; &nbsp;fi
> --
> 1.7.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>