[ovs-dev] [5088 1/2] bridge: Memory leak in port_destroy()
Ethan Jackson
ethan at nicira.com
Tue Mar 22 14:04:17 PDT 2011
I was searching for a bug in the lacp stuff and thought it might be
due to uninitialized memory so I ran through valgrind and exited with
ovs-appctl exit. It was reported as a leak. There are a couple of
other leaks actually, one or two which didn't matter, and one or two
which I plan to investigate later. This one seemed the most serious
however so I went ahead and fixed it.
Ethan
On Tue, Mar 22, 2011 at 1:56 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Mar 22, 2011 at 01:32:38PM -0700, Ethan Jackson wrote:
>> --- a/vswitchd/bridge.c
>> +++ b/vswitchd/bridge.c
>> @@ -4207,6 +4207,7 @@ port_destroy(struct port *port)
>>
>> netdev_monitor_destroy(port->monitor);
>> bitmap_free(port->trunks);
>> + free(port->bond_hash);
>> free(port->name);
>> free(port);
>
> Looks good, thank you.
>
> (How did you notice this?)
>
More information about the dev
mailing list