[ovs-dev] [cfm 4/6] packets: Create new compose_ccm() function.

[Ethan Jackson]

I guess I'm not fully understanding the purpose of the packets
library.  The definition of ccm messages is in its header file.  It
would seem natural to me for composition and parsing to be there as
well.  Furthermore, this is how it's done for lacp and "benign"
packets.  It seems like a good place to put esoteric protocol specific
logic that is only interesting in creating the packets freeing up the
caller to deal with the logic of what actually belongs in there.

On Wed, Mar 23, 2011 at 10:29 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Mar 22, 2011 at 06:32:56PM -0700, Ethan Jackson wrote:
>> This cleans up the CFM library a bit by pushing ccm composition
>> details into the packets library.
>
> I don't yet see the benefit to moving composing (patch 4) and parsing
> (patch 5) CCM packets from cfm into packets.  Can you explain?
>