[ovs-dev] [restart v2 2/3] daemon: Avoid redundant code in already_running().
blp at nicira.com
Tue Mar 29 10:10:45 PDT 2011
On Tue, Mar 29, 2011 at 09:56:49AM -0700, Justin Pettit wrote:
> On Mar 29, 2011, at 9:36 AM, Ben Pfaff wrote:
> > + pid = read_pidfile_if_exists(_pidfile)
> > + if pid > 0:
> > if not _overwrite_pidfile:
> > - msg = "%s: already running" % _pidfile
> > - logging.error(msg)
> > + msg = "%s: already running as pid %d" % (_pidfile, pid)
> > + logging.error("%s, aborting" % msg)
> > sys.stderr.write("%s\n" % msg)
> > sys.exit(1)
> This is really minor, but is there a reason to only log "aborting" in this patch and not the previous one, since I don't believe the behavior has changed?
This patch series has not been greatly to my glory.
I've fixed this now.
> Otherwise, the series looks good.
Thanks, I'll push it soon.
More information about the dev