[ovs-dev] [PATCH v3] datapath: Define net_device_ops->ndo_get_stats64() for internal_dev.

Pravin Shelar pshelar at nicira.com
Fri Nov 4 13:36:23 PDT 2011


On Fri, Nov 4, 2011 at 12:52 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Fri, Nov 4, 2011 at 11:12 AM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
>> index a468ac8..55f5e46 100644
>> --- a/datapath/vport-internal_dev.c
>> +++ b/datapath/vport-internal_dev.c
>>  static struct net_device_stats *internal_dev_sys_stats(struct net_device *netdev)
> [...]
>> +       vport_get_stats((vport), &vport_stats);
>
> You have an extra set of parentheses left over from when this was a
> macro but otherwise looks good.
> Acked-by: Jesse Gross <jesse at nicira.com>
>
thanks, pushed to master.



More information about the dev mailing list