[ovs-dev] [PATCH 2/3] datapath: Slim down the vport interface.
jesse at nicira.com
Mon Nov 7 18:26:18 PST 2011
On Mon, Nov 7, 2011 at 10:56 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Sun, Nov 06, 2011 at 12:34:24PM -0800, Jesse Gross wrote:
>> Many of the function in vport.c are simply pass throughs to their
>> underlying vport implementation and, of these, many are used only
>> for bridge compatibility code. This allows users of these functions
>> to directly call through the ops structure, reducing boilerplate code
>> and keeping more of the compatibility code together.
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
> I think that this introduces the new assumption that if 'get_ifindex'
> is implemented then 'get_mtu' must also be implemented. That should
> be either reverted or documented in a comment on 'get_mtu', I think.
Since get_mtu is only used by compatibility code now and I would like
to delete it rather than use it in more places I kept it as is but
added a comment.
More information about the dev