[ovs-dev] [#8024v2 2/5] Don't overload IP TOS with the frag matching bits.

Justin Pettit jpettit at nicira.com
Tue Nov 8 23:15:16 PST 2011


On Nov 8, 2011, at 8:13 PM, Jesse Gross wrote:

> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff <blp at nicira.com> wrote:
>> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
>>> This will be useful later when we add support for matching the ECN bits
>>> within the TOS field.
>>> 
>>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
>> 
>> I think that these |=s can become =s:
> 
> There's some instances of this in the userspace flow_extract() as well.

I think there was only one, since the flag behavior is slightly different between userspace and kernel.  You can double check my work in the incremental, though.

--Justin





More information about the dev mailing list