[ovs-dev] [metaflow-cleanup 3/3] nx-match: Fold all of its data structures into mf_field.

[Ethan Jackson]

Sounds fine to me.

Ethan

On Mon, Nov 21, 2011 at 14:44, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Nov 14, 2011 at 05:02:22PM -0800, Ethan Jackson wrote:
>> On Mon, Nov 14, 2011 at 17:00, Ben Pfaff <blp at nicira.com> wrote:
>> > On Mon, Nov 14, 2011 at 02:17:01PM -0800, Ethan Jackson wrote:
>> >> Why do we consider mf_fields which don't have a corresponding NXM
>> >> field writable? ?That wasn't obvious to me from reading the code.
>> >
>> > What code prompts that question?
>> >
>>
>> This code:
>>
>> The dl_vlan  has no NXM field but is writable.  I may be
>> misinterpreting the meaning/use of the writable boolean though.
>>
>>     }, {
>>         MFF_VLAN_VID, "dl_vlan", NULL,
>>         sizeof(ovs_be16), 12,
>>         MFM_NONE, 0,
>>         MFS_DECIMAL,
>>         MFP_NONE,
>> -        0,
>> +        true,
>> +        0, NULL
>>     }, {
>>         MFF_VLAN_PCP, "dl_vlan_pcp", NULL,
>>         1, 3,
>>         MFM_NONE, 0,
>>         MFS_DECIMAL,
>>         MFP_NONE,
>> -        0,
>> +        true,
>> +        0, NULL
>>     },
>
> I see.
>
> You're right that 'writable' is currently only used by NXM, so this
> value won't ever get used, so its value doesn't really matter.  But
> both of these fields can be modified by the datapath so I think that
> "true" seems more correct than "false".
>
> Thanks,
>
> Ben.
>