[ovs-dev] [TCP_CRR 3/6] dpif-linux: Use poll() internally in dpif_linux_recv().

Justin Pettit jpettit at nicira.com
Thu Nov 24 09:28:38 PST 2011


On Nov 22, 2011, at 3:12 PM, Ben Pfaff wrote:

>     /* Upcall messages. */
>     struct nl_sock *upcall_socks[N_UPCALL_SOCKS];
> -    int last_read_upcall;
> +    uint32_t nonempty_socks;

I think it would be helpful to point out that this is a mask--either through a comment or appending "_mask" to the name.

Otherwise, looks good.

--Justin






More information about the dev mailing list