[ovs-dev] [PATCH] ovs-ofctl: Improve usage message.
blp at nicira.com
Wed Nov 30 13:30:21 PST 2011
Thanks, I pushed this.
On Wed, Nov 30, 2011 at 01:28:13PM -0800, Justin Pettit wrote:
> Looks good.
> On Nov 30, 2011, at 1:07 PM, Ben Pfaff wrote:
> > TARGET and SWITCH are different because TARGET can refer to a switch or a
> > controller whereas SWITCH must be a switch, but TARGET wasn't defined
> > before.
> > Also, TARGET seems a little more user-friendly than the VCONN that was used
> > here before.
> > Reported-by: Reid Price <reid at nicira.com>
> > Bug #7736.
> > ---
> > utilities/ovs-ofctl.c | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> > diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> > index 7b2b186..cf77300 100644
> > --- a/utilities/ovs-ofctl.c
> > +++ b/utilities/ovs-ofctl.c
> > @@ -187,10 +187,10 @@ usage(void)
> > " replace-flows SWITCH FILE replace flows with those in FILE\n"
> > " monitor SWITCH [MISSLEN] print packets received from SWITCH\n"
> > "\nFor OpenFlow switches and controllers:\n"
> > - " probe VCONN probe whether VCONN is up\n"
> > - " ping VCONN [N] latency of N-byte echos\n"
> > - " benchmark VCONN N COUNT bandwidth of COUNT N-byte echos\n"
> > - "where each SWITCH is an active OpenFlow connection method.\n",
> > + " probe TARGET probe whether TARGET is up\n"
> > + " ping TARGET [N] latency of N-byte echos\n"
> > + " benchmark TARGET N COUNT bandwidth of COUNT N-byte echos\n"
> > + "where SWITCH or TARGET is an active OpenFlow connection method.\n",
> > program_name, program_name);
> > vconn_usage(true, false, false);
> > vlog_usage();
> > --
> > 184.108.40.206
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
More information about the dev