[ovs-dev] [STP 9/9] ovs-vswitchd: Add support for 802.1D STP.

[Justin Pettit]

On Oct 21, 2011, at 4:35 PM, Ben Pfaff wrote:

> On Fri, Oct 21, 2011 at 04:20:43PM -0700, Justin Pettit wrote:
>> On Oct 18, 2011, at 1:23 PM, Ben Pfaff wrote:
>> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
>> index 025cc5b..065acf0 100644
>> --- a/ofproto/ofproto-dpif.c
>> +++ b/ofproto/ofproto-dpif.c
>> @@ -967,6 +967,11 @@ set_stp(struct ofproto *ofproto_, const struct ofproto_stp_settings *s)
>> {
>>     struct ofproto_dpif *ofproto = ofproto_dpif_cast(ofproto_);
>> 
>> +    /* Only revalidate flows if the configuration changed. */
>> +    if (!s != !ofproto->stp) {
>> +        ofproto->need_revalidate = true;
>> +    }
> 
> Do you need to revalidate on partial changes, e.g. an stp-port-num
> change?

I don't believe that's necessary, since the STP library should change the port state if necessary, which will eventually run update_stp_port_state(), which will revalidate flows.

> Otherwise all your responses and updates look OK to me.

Thanks for the reviews.  I pushed the series.

--Justin