[ovs-dev] [cfm_v2 9/9] cfm: Write remote MPIDs to the database.

Ethan Jackson ethan at nicira.com
Fri Sep 9 13:21:25 PDT 2011


> cfm_destroy() should free ->rmps.

good catch.

Thanks for the review,

On Fri, Sep 9, 2011 at 11:39, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Sep 08, 2011 at 06:59:53PM -0700, Ethan Jackson wrote:
>> A controller may want to know which MPIDs are reachable from an
>> interface configured with CFM.  This patch regularly writes this
>> information to the database.
>>
>> Bug #7014.
>
> I think it would be nice if ofproto_port_get_cfm_remote_mpids() set
> *rmps to NULL and *n_rmps to 0 on any kind of error, for the caller's
> convenience.
>
> cfm_destroy() should free ->rmps.
>
> Otherwise this looks good, thank you.
>



More information about the dev mailing list